Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with crossPaths #172

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Build with crossPaths #172

merged 1 commit into from
Oct 20, 2024

Conversation

raboof
Copy link
Member

@raboof raboof commented Oct 20, 2024 •
edited
Loading

It's uncommon to disable this, and possibly caused the .tasty files in the staged 2.12 and 2.13 artifacts.

@raboof
Build with crossPaths
4d0e82e 
It's uncommon to enable this, and possibly caused the .tasty files
in the staged 2.12 and 2.13 artifacts.
pjfanning
pjfanning approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@raboof raboof merged commit 38d7b54 into apache:main Oct 20, 2024
8 checks passed
@pjfanning
Copy link
Contributor

@raboof will I cancel the RC1 vote and do an RC2?

@raboof
Copy link
Member Author

raboof commented Oct 20, 2024

I think it's fine to continue with the RC1 vote: while the .tasty files make the jars bigger than necessary, AFAICS they should otherwise not cause problems.

Did you publish with +? If so, maybe staging the artifacts for the different Scala versions with clean in between might publish 'clean' jars even without this change.

@pjfanning
Copy link
Contributor

The sbt-sonatype plugin that we use doesn't like me trying to publish 3 times (for 3 scala versions). It deletes any open 'repositories'.
I think it is easier to cancel the RC1 and start an RC2.

@raboof
Copy link
Member Author

raboof commented Oct 20, 2024

The sbt-sonatype plugin that we use doesn't like me trying to publish 3 times (for 3 scala versions). It deletes any open 'repositories'.

Ah, ok

I think it is easier to cancel the RC1 and start an RC2.

Works for me!

pjfanning pushed a commit to pjfanning/incubator-pekko-persistence-dynamodb that referenced this pull request Oct 20, 2024
@raboof @pjfanning
Build with crossPaths (apache#172)
74d4723 
It's uncommon to enable this, and possibly caused the .tasty files
in the staged 2.12 and 2.13 artifacts.
@pjfanning pjfanning mentioned this pull request Oct 20, 2024
Merged
raboof added a commit that referenced this pull request Oct 21, 2024
@pjfanning @raboof
Build with crossPaths (#172) (#173)
2449d10 
It's uncommon to enable this, and possibly caused the .tasty files
in the staged 2.12 and 2.13 artifacts.

Co-authored-by: Arnout Engelen <arnout@bzzt.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning pjfanning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raboof @pjfanning